-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui-control colon in group name #1554
base: main
Are you sure you want to change the base?
ui-control colon in group name #1554
Conversation
Thanks for your support, Bart. ❤️ |
Documentation you've added shows to escape it with |
It'll be because it's inside JSON I imagine. As for the whole escape using backslash - I have reservations (but cannot put my finger on why). Things like CSV usually just double up the character Ideally, We would support better structured property for specifying the page (not just a string joined by a random colon) but I understand this is a throwback from dashboard 1. In fact, I've always been super curious why we don't support the node ID. There is no ambiguity and if I ever change the title of the page, my UI control still works. |
Hi guys,
|
Yeah, I think this is the better solution, but we do need to support the existing methodology for backward compatibility. Maybe we Getting a Node's ID in Node-RED is also quite unintuitive though (especially for config nodes), so would need to improve the docs on this. |
@joepavitt |
Description
When a group name contains a colon
":"
:Then you should be able to escape (using backslashes) that colon for the ui-control node like this:
Otherwise it will trigger an error that group name "This is" cannot be found...
This PR splits only by non-escaped colons, and removes the escape characters afterwards. Then it seems to work:
Related Issue(s)
1550
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label